Enable file locking in musl stdio - #15065
Merged
Merged
Conversation
sbc100
requested review from
kleisauke and
kripken
and removed request for
kripken
September 17, 2021 17:10
Collaborator
|
Looks like the test failure in |
kleisauke
approved these changes
Sep 17, 2021
kleisauke
left a comment
kleisauke
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for keeping track of this! This looks good to me.
Member
If you also need my review, perhaps this PR could target that other PR? Then I'd just see the diff between them. (As I'm not familiar with the other PR, it would be hard for me to just review the new parts here, and I don't see an easy way on github to get that diff.) But @kleisauke 's review is probably enough already? |
sbc100
force-pushed
the
musl_threaded
branch
from
September 20, 2021 20:39
c092f47 to
5662a6c
Compare
This is second attempt at landing a version of d5d5f69 The first time we tried it #13837 we ran into issues with test_pthread_exit_process deadlocking which I tracked down to an issue with `system/lib/libc/musl/src/thread/__wait.c` where it was blocking the main thread forever rather then looping and calling `emscripten_main_thread_process_queued_calls`. Includes a version of #14481 so that should land before this does. Fixes: #13194
sbc100
force-pushed
the
musl_threaded
branch
from
September 20, 2021 20:40
5662a6c to
f96f27d
Compare
sbc100
enabled auto-merge (squash)
September 20, 2021 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is second attempt at landing a version of
d5d5f69
The first time we tried it #13837 we ran into issues with
test_pthread_exit_process deadlocking which I tracked down to an issue
with
system/lib/libc/musl/src/thread/__wait.cwhere it was blockingthe main thread forever rather then looping and calling
emscripten_main_thread_process_queued_calls.Includes a version of #14481 so that should land before this does.
Fixes: #13194